[2.9] Revert "Support transport action names when registering NamedRoutes (#7957) (#8459)"#8651
Merged
nknize merged 1 commit intoopensearch-project:2.9from Jul 12, 2023
Merged
Conversation
DarshitChanpura
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
ryanbogan,
sachinpkale,
saratvemulapalli,
setiah,
shwetathareja and
tlfeng
as code owners
DarshitChanpura
force-pushed
the
revert-8459
branch
from
79316a4 to
0e1541e
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
owaiskazi19
changed the title
owaiskazi19
approved these changes
Jul 11, 2023
Member
owaiskazi19
left a comment
owaiskazi19
left a comment
There was a problem hiding this comment.
@dbwiddis another pair of eyes
owaiskazi19
changed the title
dbwiddis
added
backport 2.x
dbwiddis
reviewed
Jul 12, 2023
Member
dbwiddis
left a comment
dbwiddis
left a comment
There was a problem hiding this comment.
QQ: I see this also reverts the bump of azure-storage-blob. Is that intended?
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.9 #8651 +/- ##
============================================
- Coverage 71.05% 70.68% -0.38%
+ Complexity 57461 57182 -279
============================================
Files 4745 4746 +1
Lines 270757 270727 -30
Branches 39961 39953 -8
============================================
- Hits 192390 191365 -1025
- Misses 62154 62922 +768
- Partials 16213 16440 +227
|
DarshitChanpura
force-pushed
the
revert-8459
branch
from
0e1541e to
ebf3ebc
Compare
Member
Author
fixed. |
…g NamedRoutes (opensearch-project#7957) (opensearch-project#8459)" This reverts commit cd82f4c. Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
force-pushed
the
revert-8459
branch
from
ebf3ebc to
6c0d877
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Member
Author
|
@dbwiddis this PR is based to 2.9. We can remove backport 2.x and backport 2.9 labels |
DarshitChanpura
removed
backport 2.x
dbwiddis
approved these changes
Jul 12, 2023
Member
|
LGTM. Please double check that the change log entry in 2.x is handled properly and this isn't included in the 2.9 section. |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Member
Author
|
The changelog entry is correct in 2.x, as this is present in 2.x. The entry is removed only from this branch. |
nknize
approved these changes
Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit cd82f4c.
Reverting due to: #8652
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.